Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fixing static app-title #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

letsjustfixit
Copy link

Fixing: that the AppBar has no access to the _dbInfo property so the app-title stays always static.

@DavidMStraub
Copy link
Member

That's true. Funnily enough, it's a leftover from the ancient Gramps Web app frontend (pre Gramps Web API), and I never bothered to change it (i.e. make it display the database name again) because I don't think it makes sense right now as long as we don't add the possibility to change the database name from the frontend. Many trees have names that are not really suitable as app header. So the to do list is

  • make database name changeable in Web API - this is already done, although I don't remember if it works only in the multi tree setup
  • make database name changeable in the frontend
  • leave one release (1 month) between this and changing the app header, to leave tree owners time to change

@DavidMStraub DavidMStraub added the blocked Issue cant be worked on right now label Nov 16, 2024
@letsjustfixit
Copy link
Author

Got it.

(For me this was essential because I have multiple trees served by the same instance and they even have some common people.
I was even thinking about assigning different color schemes to trees to make it more obvious when working with the different trees in different browser windows at the same time. I've also added the current logged in username to the user settings screen above the logout to make it obvious which test user I'm logged in with. )

We could add an optional TREE_DISPLAY_NAME property that defaults to the existing tree name as TREE is an essential reference key and TREE_DISPLAY_NAME might contain special characters illedavised to use for a key / folder name(accented characters,, unicode special characters etc..) .

@DavidMStraub
Copy link
Member

I've also added the current logged in username to the user settings screen above the logout to make it obvious which test user I'm logged in with.

Yes, #376, urgently needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue cant be worked on right now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants